Skip to content

Synchronize workflows #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2025
Merged

Conversation

matterhorn103
Copy link
Collaborator

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@@ -0,0 +1,155 @@
name: Linux Build Matrix

Check notice

Code scanning / Checkov (reported by Codacy)

Ensure top-level permissions are not set to write-all

Ensure top-level permissions are not set to write-all
@@ -0,0 +1,247 @@
name: macOS Build Matrix

Check notice

Code scanning / Checkov (reported by Codacy)

Ensure top-level permissions are not set to write-all

Ensure top-level permissions are not set to write-all
@@ -0,0 +1,190 @@
name: Windows Build Matrix

Check notice

Code scanning / Checkov (reported by Codacy)

Ensure top-level permissions are not set to write-all

Ensure top-level permissions are not set to write-all
path: openchemistry/molecules

- name: Install Qt
uses: jurplel/install-qt-action@v4

Check warning

Code scanning / Semgrep (reported by Codacy)

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.

- name: Setup tmate session
if: ${{ failure() }}
uses: mxschmitt/action-tmate@v3

Check warning

Code scanning / Semgrep (reported by Codacy)

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.
- name: Install Qt
# Only if not self-hosted
if: runner.name != 'macOS Apple Silicon'
uses: jurplel/install-qt-action@v4

Check warning

Code scanning / Semgrep (reported by Codacy)

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.
path: openchemistry/molecules

- name: Install Qt
uses: jurplel/install-qt-action@v4

Check warning

Code scanning / Semgrep (reported by Codacy)

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.

- name: Configure MSVC Command Prompt
if: runner.os == 'Windows'
uses: ilammy/msvc-dev-cmd@v1

Check warning

Code scanning / Semgrep (reported by Codacy)

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.

- name: Sign Windows release
if: github.event_name == 'push' && startsWith(github.event.ref, 'refs/tags/')
uses: signpath/github-action-submit-signing-request@v1

Check warning

Code scanning / Semgrep (reported by Codacy)

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.

- name: Setup tmate session
if: failure()
uses: mxschmitt/action-tmate@v3

Check warning

Code scanning / Semgrep (reported by Codacy)

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.
@matterhorn103 matterhorn103 marked this pull request as draft January 20, 2025 17:07
@matterhorn103 matterhorn103 marked this pull request as ready for review June 18, 2025 16:40
Signed-off-by: Matthew J. Milner <[email protected]>
@matterhorn103 matterhorn103 requested a review from ghutchis June 19, 2025 14:00
@matterhorn103
Copy link
Collaborator Author

matterhorn103 commented Jun 19, 2025

@ghutchis Thinking about it, wouldn't it be better to just have a single set of workflow files for building the program itself – under either the main openchemistry repo or in avogadroapp, and then reuse or trigger those from the other repos?

That's a question for after this is merged though.

@matterhorn103
Copy link
Collaborator Author

@ghutchis this is ready to go :)

Signed-off-by: Matthew J. Milner <[email protected]>
@ghutchis
Copy link
Member

It would be great to have one set of workflows. I just don't know how to do that at the moment, given the different checkout parameters, paths in AppImage, etc.

If you (or others) want to put some time into a set of unified workflows, I'd definitely appreciate it. Right now, I'm trying to put more into the C++ as well as the Qt6-CMake bits for the Mac and Windows packages.

@ghutchis ghutchis added the build label Jun 20, 2025
@ghutchis ghutchis merged commit 4307b56 into OpenChemistry:master Jun 20, 2025
33 of 36 checks passed
Copy link
Contributor

Here are the build results
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants