Android setup: More aggressive change #3642
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 9, 2024 11:14
Adding the official definitions for a cmake Android NDK cross build. Overall, this should simplify things over time. Notably, it makes the cmake ANDROID variable defined. This is the "official" way to determine an Android build and makes it possible to detect an Android build without resorting to the OpenCPN specific QT_ANDROID Definitions copied form shipdriver where they have been used for long. Merging this PR will need updating the complete Android buld chain with similar definitions.
|
The build errors are because I accidentally aborted the build. It does build by me, though EDIT: all ok after rebuilding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more aggressive alternative to #3632. Key changes:
Interestingly, this setup reveals two Android build errors which are not visible in #3632 or master. Somehow, this seems more picky which then would be for the better