-
Notifications
You must be signed in to change notification settings - Fork 123
Fix "isReady" method on inject #3336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/current
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/current #3336 +/- ##
=====================================================
+ Coverage 44.23% 44.31% +0.07%
- Complexity 2633 2654 +21
=====================================================
Files 722 725 +3
Lines 21974 22030 +56
Branches 1502 1503 +1
=====================================================
+ Hits 9720 9762 +42
- Misses 11731 11745 +14
Partials 523 523 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it might need a database migration to account for existing contracts not having the new field names (and having old ones that arent' recognised anymore)
openbas-model/src/main/java/io/openbas/database/model/InjectorContract.java
Outdated
Show resolved
Hide resolved
91b9316
to
f0f1774
Compare
f0f1774
to
ed60387
Compare
No migration is needed because contracts are automatically updated at application startup. This process ensures that existing contracts are aligned with the new field structures, handling both legacy fields and newly introduced ones seamlessly. |
Proposed changes
Linked to: