Skip to content

Fix "isReady" method on inject #3336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: release/current
Choose a base branch
from
Open

Conversation

RomuDeuxfois
Copy link
Member

@RomuDeuxfois RomuDeuxfois commented Jun 10, 2025

Proposed changes

  • Fix is ready method on inject
    • mandatory
    • mandatory group
    • mandatory on condition
  • Add tests
  • Fix i18n thanks to WWT feedbacks

Linked to:

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.31%. Comparing base (7bee250) to head (d4274a1).
Report is 5 commits behind head on release/current.

Files with missing lines Patch % Lines
.../io/openbas/injectors/caldera/CalderaContract.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #3336      +/-   ##
=====================================================
+ Coverage              44.23%   44.31%   +0.07%     
- Complexity              2633     2654      +21     
=====================================================
  Files                    722      725       +3     
  Lines                  21974    22030      +56     
  Branches                1502     1503       +1     
=====================================================
+ Hits                    9720     9762      +42     
- Misses                 11731    11745      +14     
  Partials                 523      523              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RomuDeuxfois RomuDeuxfois changed the title Fix is ready method on inject Fix "isReady" method on inject Jun 10, 2025
@antoinemzs antoinemzs requested review from antoinemzs June 16, 2025 08:47
Copy link
Contributor

@antoinemzs antoinemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it might need a database migration to account for existing contracts not having the new field names (and having old ones that arent' recognised anymore)

@RomuDeuxfois RomuDeuxfois changed the base branch from master to release/current June 16, 2025 11:38
@RomuDeuxfois
Copy link
Member Author

This looks like it might need a database migration to account for existing contracts not having the new field names (and having old ones that arent' recognised anymore)

No migration is needed because contracts are automatically updated at application startup. This process ensures that existing contracts are aligned with the new field structures, handling both legacy fields and newly introduced ones seamlessly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants