[backend] Improve Crowdstrike executor #2760
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 25, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/current #2760 +/- ##
=====================================================
- Coverage 40.41% 40.18% -0.24%
- Complexity 2068 2070 +2
=====================================================
Files 635 636 +1
Lines 19451 19589 +138
Branches 1325 1340 +15
=====================================================
+ Hits 7862 7871 +9
- Misses 11158 11287 +129
Partials 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Dimfacion
reviewed
Mar 25, 2025
openbas-api/src/main/java/io/openbas/executors/crowdstrike/CrowdStrikeExecutor.java
Outdated
Show resolved
Hide resolved
Dimfacion
reviewed
Mar 25, 2025
...bas-api/src/main/java/io/openbas/executors/crowdstrike/client/CrowdStrikeExecutorClient.java
Outdated
Show resolved
Hide resolved
Dimfacion
reviewed
Mar 25, 2025
...bas-api/src/main/java/io/openbas/executors/crowdstrike/client/CrowdStrikeExecutorClient.java
Outdated
Show resolved
Hide resolved
Dimfacion
reviewed
Mar 25, 2025
...bas-api/src/main/java/io/openbas/executors/crowdstrike/client/CrowdStrikeExecutorClient.java
Outdated
Show resolved
Hide resolved
Dimfacion
reviewed
Mar 25, 2025
...s-api/src/main/java/io/openbas/executors/crowdstrike/service/CrowdStrikeExecutorService.java
Outdated
Show resolved
Hide resolved
Dimfacion
reviewed
Mar 25, 2025
Dimfacion
requested changes
Mar 25, 2025
…or (#2653) Co-authored-by: Yann <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Romuald Lemesle <[email protected]>
Dimfacion
reviewed
Mar 27, 2025
| List<CrowdStrikeDevice> devices = this.client.devices(hostGroup); | ||
| Optional<AssetGroup> existingAssetGroup = | ||
| assetGroupService.findByExternalReference(hostGroup); | ||
| CrowdStrikeHostGroup crowdStrikeHostGroup = |
There was a problem hiding this comment.
issue : Several things here - If there is an issue here (for instance, I just got a 403), this.client.hostGroup(hostGroup).getResources() will be null, leading to a NPE. Besides, we don't log anything even though CS sent us the error code and message. Last thing but let's say we had this issue and we raised an exception, we won't populate for the next host group.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
guillaumejparis
force-pushed
the
release/current
branch
from
7e5edeb to
408f0bd
Compare
guillaumejparis
force-pushed
the
release/current
branch
from
ded0569 to
7ec815e
Compare
Dimfacion
reviewed
Mar 31, 2025
| if (crowdStrikeResourceGroup.getErrors() != null | ||
| && !crowdStrikeResourceGroup.getErrors().isEmpty()) { | ||
| CrowdstrikeError e = crowdStrikeResourceGroup.getErrors().getFirst(); | ||
| log.log( |
There was a problem hiding this comment.
I'm gonna nitpick here but could you merge all the errors into the error message to not only show the first one ?
Dimfacion
reviewed
Mar 31, 2025
| + e.getMessage()); | ||
| continue; | ||
| } | ||
| List<CrowdStrikeDevice> devices = this.client.devices(hostGroup); |
There was a problem hiding this comment.
Again, nitpicking here but could you add error handling here like you did above ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...