Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/backend] Show expectations traces (#564) #2598

Merged
merged 25 commits into from
Mar 31, 2025

Conversation

johanah29
Copy link
Member

@johanah29 johanah29 commented Mar 4, 2025

Closes #564

@johanah29 johanah29 added the filigran team use to identify PR from the Filigran team label Mar 4, 2025
@johanah29 johanah29 changed the base branch from master to release/current March 4, 2025 09:13
@johanah29 johanah29 force-pushed the issue/564 branch 2 times, most recently from 66032e4 to 7af9369 Compare March 10, 2025 12:25
@johanah29 johanah29 force-pushed the issue/564 branch 2 times, most recently from a9453bb to cc03404 Compare March 17, 2025 08:28
@savacano28 savacano28 self-requested a review March 21, 2025 15:08
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 78.82353% with 18 lines in your changes missing coverage. Please review.

Project coverage is 40.59%. Comparing base (7ec815e) to head (7cd3522).
Report is 2 commits behind head on release/current.

Files with missing lines Patch % Lines
...va/io/openbas/rest/expectation/ExpectationApi.java 21.05% 14 Missing and 1 partial ⚠️
...openbas/service/InjectExpectationTraceService.java 84.21% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #2598      +/-   ##
=====================================================
+ Coverage              40.44%   40.59%   +0.15%     
- Complexity              2068     2081      +13     
=====================================================
  Files                    635      638       +3     
  Lines                  19441    19518      +77     
  Branches                1323     1324       +1     
=====================================================
+ Hits                    7862     7924      +62     
- Misses                 11148    11161      +13     
- Partials                 431      433       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@johanah29 johanah29 force-pushed the issue/564 branch 2 times, most recently from 4c4635f to 398a9ae Compare March 24, 2025 12:06
@johanah29 johanah29 marked this pull request as ready for review March 24, 2025 14:53
@johanah29 johanah29 linked an issue Mar 25, 2025 that may be closed by this pull request
return simpleCall(uri);
};

export const getAlertLinksCount = (injectExpectationId: string, sourceId: string | undefined, expectationResultSourceType: string | undefined) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: sourceId can't be null for the back-end. So we need to be aligned here.

@guillaumejparis guillaumejparis changed the title [frontend | backend] Show expectations traces (#564) [frontend/backend] Show expectations traces (#564) Mar 31, 2025
@impolitepanda impolitepanda merged commit f9b9f20 into release/current Mar 31, 2025
7 checks passed
@impolitepanda impolitepanda deleted the issue/564 branch March 31, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show prevention/detection alerts (EDR/SIEM)
3 participants