Skip to content

Fix SSD1306 build #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

julianneswinoga
Copy link
Member

Fixes #262

  • Updated CI to build with INFO_DISPLAY_TYPE, but only for mksgenlv21 and esp32
    • Needed to add in some more constraints based on the firmware:
    • AVR-based boards can only have DISPLAY_TYPE OR INFO_DISPLAY_TYPE, not both
    • MKS Gen L-based boards can't have INFO_DISPLAY_TYPE and a focus motor (from their pin configuration)
  • Fix the https://github.com/ClutchplateDude/esp8266-oled-ssd1306#4.6.0 tag specifier, because the 4.6.0 tag is before @ClutchplateDude fixed the library. 4.6.2 tag is now correct.
  • Apparently the esp32 build with INFO_DISPLAY_TYPE_I2C_SSD1306_128x64 was just broken? pgm_read_byte() on esp32 (which is just a pointer cast because esp32 doesn't actually have PROGMEM) does a useless cast which fails with our warning flags

Copy link
Member

@ClutchplateDude ClutchplateDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@julianneswinoga julianneswinoga merged commit fe5e685 into OpenAstroTech:develop Apr 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building with SSD1306 broken
2 participants