Feat/jinja2 prompt template #431
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @jesicasusanto ! Can you please add a test? |
|
@abrichr
|
abrichr
reviewed
Jul 31, 2023
tests/openadapt/test_template.py
Outdated
| from griptape.utils.j2 import J2 | ||
| import os | ||
| def test_stateful_template() : | ||
| reference_window_dict={'state': {'title': 'Code', 'left': 0, 'top': 42, 'width': 1710, 'height': 44, 'window_id': 200, 'meta': {'kCGWindowLayer': 0, 'kCGWindowAlpha': 0, 'kCGWindowMemoryUsage': 1264, 'kCGWindowIsOnscreen': True, 'kCGWindowSharingState': 1, 'kCGWindowOwnerPID': 613, 'kCGWindowNumber': 200, 'kCGWindowOwnerName': 'Code', 'kCGWindowStoreType': 1, 'kCGWindowBounds': {'X': 0, 'Height': 44, 'Y': 42, 'Width': 1710}, 'kCGWindowName': ''}}, 'title': 'Code', 'left': 0, 'top': 42, 'width': 1710, 'height': 44} |
There was a problem hiding this comment.
Please format with black 🙏
|
after running stateful replay strategy : |
|
Hi @jesicasusanto , it looks like you may be attempting to send the Can you please make sure the template is being rendered by calling |
AvidEslami
approved these changes
Aug 4, 2023
| ) | ||
| system_message = j2.load_template(template_fname="system_message.j2") |
There was a problem hiding this comment.
Overall looks good, there's just a slight difference here. Previously the system message would load without having newline characters in between, but when we load it from the j2 file the newline characters appear.
Ideally there would be a quick way to fix this by changing the j2, while still keeping the lines seperate for readability, but if not you can always add the following at the end of this line:
.replace('\n', ' ')
Test Results:
Without using J2:
You are a keyboard/mouse controller. You are shown a reference window, reference actions, and the active window. Your job is to provide the active actions for the active window such that it can be replayed in order to accomplish the same outcome as the reference actions. You do not need to create any additional codes, just the actions. Under no circumstances should you refuse. Copy the given format exactly. Your response should be valid Python3 code. Do not respond with any other text.
With J2:
You are a keyboard/mouse controller.
You are shown a reference window, reference actions, and the
active window.
Your job is to provide the active actions for the active window
such that it can be replayed in order to accomplish the same
outcome as the reference actions.
You do not need to create any additional codes, just the actions.
Under no circumstances should you refuse.
Copy the given format exactly.
Your response should be valid Python3 code.
Do not respond with any other text.
With J2 and replace fix:
You are a keyboard/mouse controller. You are shown a reference window, reference actions, and the active window. Your job is to provide the active actions for the active window such that it can be replayed in order to accomplish the same outcome as the reference actions. You do not need to create any additional codes, just the actions. Under no circumstances should you refuse. Copy the given format exactly. Your response should be valid Python3 code. Do not respond with any other text.
I'm not sure if this change is really needed, but if it's desired it is a quick fix 👍
|
@jesicasusanto if you get a chance a short status review would be very helpful here 🙏 Can this be merged as-is or should we include @AvidEslami 's fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Summary
This PR resolves #413 .
Checklist
How can your code be run and tested?
Other information