-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kotlin] [Retrofit2] [Coroutines] [Client] Option to remove Response<> wrapper in operation return types #20613
base: master
Are you sure you want to change the base?
Conversation
ad4eb93
to
0563ce7
Compare
Hi, could you please check the CI errors? Thanks |
Should be fixed now. Too eager refactoring by Intellij :) |
2e4b0e3
to
48e90cf
Compare
…tines api template (OpenAPITools#15491)
48e90cf
to
d8bdbf9
Compare
Could you please add this flag to an existing sample project? |
IMHO this one https://github.com/OpenAPITools/openapi-generator/blob/master/bin/configs/unmaintained/kotlin-jvm-retrofit2-coroutines.yaml would be the best one. |
You are right. I don't know why that's unmaintained, maybe @wing328 can add some more information on why it's unmaintained. |
if i remember correctly, the build fails but no one has time to look into it can you try building the sample locally to see if it builds fine for you? |
Sure, I will take a look tomorrow |
Indeed this sample does not compile but I changed |
Fixes (#15491)
Add option
useResponseAsReturnType
to disable generating ofResponse<T>
return type insuspend
retrofit2 api methodsPR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier @e5l