Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix associative container on Json values in UE4cpp #20606

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roseatromero
Copy link
Contributor

Similar to #17684

Fixes compiler error when using "uniqueItems": true, in the schema

11>JsonWriter.h(211): Error C2665 : 'TJsonWriter<TCHAR,TPrettyJsonPrintPolicy<CharType>>::WriteValueOnly': no overloaded function could convert all the argument types
        

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
  • [ ]
    Tagging @Kahncode for visibility

@Kahncode
Copy link
Contributor

Kahncode commented Feb 9, 2025

Looks good, thanks for the PR @roseatromero.

Did you have this locally for a long time? Your previous change would not have worked for Sets without it.

@roseatromero
Copy link
Contributor Author

Looks good, thanks for the PR @roseatromero.

Did you have this locally for a long time? Your previous change would not have worked for Sets without it.

I could be wrong, but I believe it was working but only for serialization ,and not for deserialization (we were sending requests instead of receiving unique values as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants