-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C#] use nullable class in petstore openapi spec #20585
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bug on dictionary type when using nullableReferenceType
/// Gets or Sets ObjectNullableProp | ||
/// </summary> | ||
[DataMember(Name="object_nullable_prop", EmitDefaultValue=true)] | ||
public Dictionary?<string, Object> ObjectNullableProp { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nullable reference is not working correctly when enabled on dictionary. From current implementation, it should be treated as Dictionary<string, Object>
though subsequently it should be fixed to address as Dictionary<string, Object>?
/// Gets or Sets ObjectAndItemsNullableProp | ||
/// </summary> | ||
[DataMember(Name="object_and_items_nullable_prop", EmitDefaultValue=true)] | ||
public Dictionary?<string, Object?> ObjectAndItemsNullableProp { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nullable reference is not working correctly when enabled on dictionary. From current implementation, it should be treated as Dictionary<string, Object?>
though subsequently it should be fixed to address as Dictionary<string, Object?>?
/// Gets or Sets ObjectNullableProp | ||
/// </summary> | ||
[DataMember(Name="object_nullable_prop", EmitDefaultValue=true)] | ||
public Dictionary?<string, Object> ObjectNullableProp { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nullable reference is not working correctly when enabled on dictionary. From current implementation, it should be treated as Dictionary<string, Object>
though subsequently it should be fixed to address as Dictionary<string, Object>?
/// Gets or Sets ObjectAndItemsNullableProp | ||
/// </summary> | ||
[DataMember(Name="object_and_items_nullable_prop", EmitDefaultValue=true)] | ||
public Dictionary?<string, Object?> ObjectAndItemsNullableProp { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nullable reference is not working correctly when enabled on dictionary. From current implementation, it should be treated as Dictionary<string, Object?>
though subsequently it should be fixed to address as Dictionary<string, Object?>?
85025ca
to
0491c1d
Compare
0491c1d
to
e2dad12
Compare
Update petstore spec with more complete testing of nullable properties.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)