Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to allow response enum additions #532

Closed

Conversation

westse
Copy link
Contributor

@westse westse commented Jun 15, 2023

  • Default behavior unchanged to not allow response enum additions.
  • Adds option to allow response enum additions, both in CLI and programmatically
  • Tests added for new behavior related to lenient vs strict response enum behavior
  • Tests also added for request enum behavior (which has been left unchanged).

Fixes #303

westse added 2 commits June 15, 2023 10:35
- Addresses issue OpenAPITools#303
- Default behavior unchanged to not allow response enum additions.
- Adds option to allow response enum additions, both in CLI and programmatically
- Tests added for new behavior related to lenient vs strict response enum behavior
- Tests also added for request enum behavior (which has been left unchanged).
- Document allow-response-enum-additions
@joschi joschi added this to the 2.1.0 milestone Jul 25, 2023
@joschi joschi changed the title Fix #303 - Option to allow response enum additions Add option to allow response enum additions Jul 25, 2023
Copy link
Contributor

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@westse Thanks for your contribution! Would you mind to rebase this PR onto the latest master branch?

@westse
Copy link
Contributor Author

westse commented Jul 26, 2023

Closing in favor of #552 which is a more-general solution.

@westse westse closed this Jul 26, 2023
@westse westse deleted the allow-response-enum-additions branch July 26, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENUM changes
2 participants