Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2426 Build on GitHub Actions instead of AppVeyor #2428

Merged
merged 16 commits into from
Feb 19, 2025

Conversation

rwmcintosh
Copy link
Member

Fixes #2426

Mainly just re-writing the CI script for GHA but I did reorganize the test scripts a little bit to remove dependencies on IntegrationsTests.dll which was being used by other test projects.

@rwmcintosh
Copy link
Member Author

I'll get coverage updating here before merge

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.20%. Comparing base (4fa3be9) to head (44cf4b5).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
tests/OSPSuite.HelpersForTests/AssertForSpecs.cs 42.85% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2428       +/-   ##
============================================
+ Coverage     0.00%   80.20%   +80.20%     
============================================
  Files         1346     2352     +1006     
  Lines        41137    94551    +53414     
  Branches      2915        0     -2915     
============================================
+ Hits             1    75838    +75837     
+ Misses       41136    18713    -22423     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rwmcintosh rwmcintosh requested a review from Yuri05 February 19, 2025 19:02
@rwmcintosh
Copy link
Member Author

We can check the coverage run tomorrow. It's set up for Thursdays at 1AM UTC

@rwmcintosh
Copy link
Member Author

We can check the coverage run tomorrow. It's set up for Thursdays at 1AM UTC

If PR doesn't merge until tomorrow then I'll just switch the coverage schedule to Friday.

@Yuri05 Yuri05 merged commit 1e261be into develop Feb 19, 2025
4 checks passed
@Yuri05 Yuri05 deleted the 2426-build-on-github-actions-instead-of-appveyor branch February 19, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Build on GitHub Actions instead of AppVeyor
3 participants