Update readme.md to include important info #90
Conversation
|
Hey @sandygudie, please review my pr |
README.md
Outdated
| - Any page you code has to be responsive. | ||
| - Write clear and concise commit messages. | ||
| - Always run `yarn` after pulling code from the upstream repository. | ||
| - Always, **Always** make pull requests to the **dev** branch, not the main branch. All pull requests to the main branch will not be merged. |
There was a problem hiding this comment.
Welldone @JulianaSau
...."to the dev_team2 branch"...
please
README.md
Outdated
|
|
||
| - Open [http://localhost:3000](http://localhost:3000) with your browser to see the result. |
There was a problem hiding this comment.
The Vite app default port is 5173, it does not open at 3000 (unless customized)
|
Thanks for the review. I've updated the pr with the requested changes and also updated the screenshots to reflect the new changes. |
|
@BatoolMM this is ready for merging |
|
@all-contributors please add @sandygudie for mentoring |
|
I've put up a pull request to add @sandygudie! 🎉 |
|
Just saw this - you now have merge privileges for the MOOCs Frontend development. |
…aSau/feat/update-ReadMe Update readme.md to include important info
Summary
Fixes #70
Addresses #10
Updating README.md with more information about the project and repository and include information important to new contributors
List of changes proposed in this PR (pull-request)
Screenshots
What should a reviewer concentrate their feedback on?