-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup husky and lint-staged #69
Setup husky and lint-staged #69
Conversation
@JulianaSau well done on this 👏, it's great |
Hi. Thank you for reviewing my pr module.exports = {
'*.{js,jsx}': ['yarn lint'],
'*.{js,json,css,jsx}': ['yarn format'],
} So the I've added so for clarity, should the pre-commit also run the global checks or just on the staged files? |
Yeah, the pre-commit should run only on staged files. |
@all-contributors add @JulianaSau for infra |
I've put up a pull request to add @JulianaSau! 🎉 |
@all-contributors add @JulianaSau for infra |
@JulianaSau already contributed before to infra |
@all-contributors add @JulianaSau for Ideas & Planning |
I've updated the pull request to add @JulianaSau! 🎉 |
@JulianaSau Good Job |
Thank you😁 |
…aSau/dev_team2 Setup husky and lint-staged
Summary
Fixes #66
Addresses #10
Automation of linting and code formatting to enforce a uniform code style for contributors on the repo
List of changes proposed in this PR (pull-request)
husky
,lint-staged
,prettier
,eslint
and their peer dependencieseslint
andprettier
ruleshusky
andlint-staged
to automate linting and formattingprettier --write
to fix the existing code formatting errorseslint --fix
to rectify the linting errors existing in the codebaseWhat should a reviewer concentrate their feedback on?