-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: restrict the Windows Hello-related libraries from running in child processes. #6108
base: x
Are you sure you want to change the base?
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -904,6 +913,7 @@ if (!singleInstance && !process.mas) { | |||
app.on('ready', async () => { | |||
const locale = await initLocale(); | |||
logger.info('locale >>>> ', locale); | |||
startServices(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
之前已经有一个 process 文件夹,用来跑子进程,可以看一下 initChildProcess
代码结构应该可以收拢到一起
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看了下,有点区别。
process 里面的代码是通过 node 的 child_process 中执行,在一个子进程沙盒里面,不能直接访问 electron 了,然后 http 通信,
然后 service 这里的代码是通过 UtilityProcess 挂载到类似 Chrome 的 Services API 中执行,可以继续访问 Electorn 模块,可以靠事件通信。
感觉合不到一块儿,😳。
后续如果还有 Native Addons,可以继续往 service 上加。
No description provided.