Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: generate presetNetwork file from server #5410

Draft
wants to merge 9 commits into
base: x
Choose a base branch
from

Conversation

originalix
Copy link
Contributor

No description provided.

Copy link

codesandbox bot commented Aug 4, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@originalix originalix marked this pull request as draft August 4, 2024 12:18
Copy link

what-the-diff bot commented Aug 4, 2024

PR Summary

  • Network Data Retrieval Enhancements
    Routine established to fetch, sanitize, format, and write network data from external API resources. Any previous data files are removed to prevent redundancy. Code quality ensured via automatic linting of the generated file.
  • Package.json Modifications
    Integration of the new routine into package.json, now executable via "fetch:networks" command.
  • Types Modifications
    Fine-tuning of network handling interfaces with the addition of flexibility options and removal of less used properties for improved efficiency.


// Group networks by impl
const networkGroups = {};
networks.forEach((network) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getNetworkIdsMap 也可以在预生成好,减少运行时计算量

Copy link

Report too large to display inline

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: node scripts/postinstall
🚫
Install scripts npm/[email protected] 🚫

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants