Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default actor #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ninjaprox
Copy link

This PR is to unset the default value of actor input, otherwise INPUT_ACTOR will be always "GITHUB_ACTOR" instead of GITHUB_ACTOR env var if the input is omitted.

@OleksiyRudenko
Copy link
Owner

OleksiyRudenko commented Nov 14, 2022

@ninjaprox Thank you for noticing this and suggesting a fix. A stupid mistake from my side.
Now, I am thinking of setting the default value as ${{ github.actor }}, which effectively dubs GITHUB_ACTOR env variable. Having this defined in action.yml seems to be more obvious and consistent.
What do you think?

@ninjaprox
Copy link
Author

ninjaprox commented Nov 15, 2022

@OleksiyRudenko I'm not sure if ${{ github.actor }} works in action.yml, expressions seem to work only in workflow files. Mentioning it in the description should suffice for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants