-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/calculate price #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will be probably a conflict with changes I made here #42 Especially
fetch price details in accessDetails from blockchain instead of offchain record which is not ready yet - oceanprotocol/ocean-node#525
I basically removed the dependency on the offchain
record since it is not ready in ocean-node yet. Maybe we don't need it also in this feature. Price can be fetched from the blockchain directly. Here is the code I wrote for that https://github.com/OceanProtocolEnterprise/market/pull/42/files#diff-efa075d38c531ad33cc66d81dcf0c2b6e0d100ec007929734503c46b2dce699c
ok, so first we have to merge your pr, then i update mine. What do you think? |
Agree. I just merged my PR to |
for testing:
run barge and node (ocean elastic search branch)
use cli to publish a daset and add algoritmh and services