Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/calculate price #43

Merged
merged 19 commits into from
Sep 17, 2024
Merged

Feat/calculate price #43

merged 19 commits into from
Sep 17, 2024

Conversation

AdriGeorge
Copy link

@AdriGeorge AdriGeorge commented Sep 16, 2024

image

for testing:
run barge and node (ocean elastic search branch)
use cli to publish a daset and add algoritmh and services

Copy link

@FilipMasar FilipMasar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be probably a conflict with changes I made here #42 Especially

fetch price details in accessDetails from blockchain instead of offchain record which is not ready yet - oceanprotocol/ocean-node#525

I basically removed the dependency on the offchain record since it is not ready in ocean-node yet. Maybe we don't need it also in this feature. Price can be fetched from the blockchain directly. Here is the code I wrote for that https://github.com/OceanProtocolEnterprise/market/pull/42/files#diff-efa075d38c531ad33cc66d81dcf0c2b6e0d100ec007929734503c46b2dce699c

@AdriGeorge
Copy link
Author

There will be probably a conflict with changes I made here #42 Especially

fetch price details in accessDetails from blockchain instead of offchain record which is not ready yet - oceanprotocol/ocean-node#525

I basically removed the dependency on the offchain record since it is not ready in ocean-node yet. Maybe we don't need it also in this feature. Price can be fetched from the blockchain directly. Here is the code I wrote for that https://github.com/OceanProtocolEnterprise/market/pull/42/files#diff-efa075d38c531ad33cc66d81dcf0c2b6e0d100ec007929734503c46b2dce699c

ok, so first we have to merge your pr, then i update mine. What do you think?

@FilipMasar
Copy link

There will be probably a conflict with changes I made here #42 Especially

fetch price details in accessDetails from blockchain instead of offchain record which is not ready yet - oceanprotocol/ocean-node#525

I basically removed the dependency on the offchain record since it is not ready in ocean-node yet. Maybe we don't need it also in this feature. Price can be fetched from the blockchain directly. Here is the code I wrote for that https://github.com/OceanProtocolEnterprise/market/pull/42/files#diff-efa075d38c531ad33cc66d81dcf0c2b6e0d100ec007929734503c46b2dce699c

ok, so first we have to merge your pr, then i update mine. What do you think?

Agree. I just merged my PR to ocean-node branch

src/@types/AssetExtended.d.ts Outdated Show resolved Hide resolved
src/@types/Price.d.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/Asset/AssetActions/Download/index.tsx Outdated Show resolved Hide resolved
@AdriGeorge AdriGeorge merged commit d6c2d1a into ocean-node Sep 17, 2024
@AdriGeorge AdriGeorge deleted the feat/calculate-price branch September 19, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants