Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple services - consuming support #41

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

FilipMasar
Copy link

@FilipMasar FilipMasar commented Jul 18, 2024

partially fixes #16

What was done?

  • support multiple services when viewing and downloading the asset (compute type was not tested). Edit asset was not updated yet
  • AccessDetails type on AssetExtended was changed to an array (1 accessDetails per each service)
  • AccessDetails are filled from offchain metadata (link to ocean-node issue). Previously it was fetched from Subgraph which is no longer supported in ocean-node
image

To publish an asset with multiple services you can use ocean-cli - this PR can help you. You need to do 3 steps:

  1. publish asset
  2. addService
  3. edit metadata to contain offchain

What is missing?

  • downloading 2nd, 3rd, ... service doesn't work. Issue created in ocean-node
  • filling rest of AccessDetails with real data (isPurchasable, isOwned, validOrderTx, ...)
  • testing consuming compute services
  • editing asset (editing services) DONE here Edit multiple services #42

@FilipMasar FilipMasar requested a review from a team as a code owner July 18, 2024 10:55
@FilipMasar FilipMasar changed the base branch from main to ocean-node August 2, 2024 07:37
@FilipMasar FilipMasar merged commit 602b5d2 into ocean-node Aug 2, 2024
@FilipMasar FilipMasar deleted the support-multiple-services branch August 2, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants