Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Field.to_write and FieldSet.to_write methods #1938

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

erikvansebille
Copy link
Member

This PR removes the Field.to_write and FieldSet.to_write methods, as Field writing can be handled natively by xarray in v4

  • Chose the correct base branch (main for v3 changes, v4-dev for v4 changes)

Copy link
Contributor

@VeckoTheGecko VeckoTheGecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Pushed a small edit

@VeckoTheGecko
Copy link
Contributor

VeckoTheGecko commented Mar 13, 2025

I'll rebase and enable automerge again

As Field.to_write has been removed for now; will have to be implemented via xarray directly
@VeckoTheGecko VeckoTheGecko force-pushed the removing_field_towrite branch from fb2b61f to 46afa8c Compare March 13, 2025 15:23
@erikvansebille erikvansebille merged commit 3c21377 into v4-dev Mar 13, 2025
16 checks passed
@erikvansebille erikvansebille deleted the removing_field_towrite branch March 13, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants