Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heuristic Waterfall Implementation #58

Merged
merged 10 commits into from
Aug 3, 2023
Merged

Heuristic Waterfall Implementation #58

merged 10 commits into from
Aug 3, 2023

Conversation

samparsky
Copy link
Collaborator

@samparsky samparsky commented Aug 1, 2023 •
edited
Loading

fixes #55 #54 #53

OisinKyne
OisinKyne approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@OisinKyne OisinKyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Needs to document the limit of an ERC20 token balance where it would break (> unit96)
  • Needs to document how it will fail in the worst case scenario slashings of > 16 ether.

@samparsky samparsky merged commit 7f82d0a into main Aug 3, 2023
1 check passed
@OisinKyne OisinKyne deleted the develop branch October 10, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OisinKyne OisinKyne OisinKyne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Heuristic Waterfall Contract Test Suite
2 participants
@samparsky @OisinKyne