-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added initial version for rocket pool recipient #140
base: main
Are you sure you want to change the base?
Conversation
…o feat/rocket-pool
// bytes) | ||
uint256 internal constant TRANCHES_OFFSET = 40; | ||
|
||
function rpStorage() public pure returns (address) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's store the rpStorage as an immutable variable as it won't change. Using it as a CWIA means we pay gas cost on every txn
import {Ownable} from "solady/auth/Ownable.sol"; | ||
|
||
//https://docs.rocketpool.net/overview/contracts-integrations | ||
contract ObolRocketPoolStorage is Ownable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for this contract and why the below isn't gotten at runtime from the following the docs example? https://docs.rocketpool.net/developers/usage/contracts/contracts#interacting-with-rocket-pool
address public rocketPoolStorage;
address public rocketPoolDeposit;
address public rocketPoolMinipoolManager;
address public rEth;
No description provided.