Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heuristic Waterfall Contract Test Suite #55

Closed
boulder225 opened this issue Jul 28, 2023 · 0 comments · Fixed by #57 or #58
Closed

Heuristic Waterfall Contract Test Suite #55

boulder225 opened this issue Jul 28, 2023 · 0 comments · Fixed by #57 or #58
Assignees

Comments

@boulder225
Copy link

🎯 Problem to be solved

There is a need to modify the waterfall implementation to allow for values below a certain threshold to flow to tranches. This will enable setting a low fee threshold that can go to the reward address first, allowing a node operator to receive a cut of CL rewards without exiting the validator(s). Therefore, the problem to be solved is to test this enhanced functionality to accommodate a more flexible reward distribution system.

🛠️ Proposed solution

  1. Smart Contract Testing: Implement a comprehensive test suite to thoroughly test the heuristic waterfall contract and factory with the new fee threshold feature. The test suite should cover various scenarios, edge cases, and possible exceptions to ensure the solidity of the contracts.

  2. Gas Optimization: Carefully review the contracts' gas usage during testing and optimize the code wherever possible to reduce transaction costs and improve overall performance.

  3. Documentation: Provide clear and comprehensive documentation for the test suite, detailing the purpose of each test case, the expected outcomes, and any relevant instructions for developers to follow when running the tests.

By implementing the proposed solution and conducting thorough testing, we can ensure a robust and efficient heuristic waterfall contract and factory, capable of handling rewards distribution with a configurable fee threshold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants