Skip to content

app: combined service.name #3657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Conversation

pinebit
Copy link
Collaborator

@pinebit pinebit commented Apr 17, 2025

Tempo does not support indexing on service.namespace attribute which we use to reflect the cluster hash.
Therefore, Grafana Explore does not render a filter for this attribute.
To improve usability and querying performance, we combine 7-characters cluster hash and service name (node name): {resource.service.name="fc7fc15/kurtosis-node1"}. Such the combined service name would be pretty unique across all clusters and will simplify the search.

category: misc
ticket: none

Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.66%. Comparing base (f7a2544) to head (8cc02e7).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
app/app.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3657      +/-   ##
==========================================
- Coverage   53.68%   53.66%   -0.02%     
==========================================
  Files         223      223              
  Lines       35367    35373       +6     
==========================================
- Hits        18986    18983       -3     
- Misses      14274    14281       +7     
- Partials     2107     2109       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Apr 22, 2025
@obol-bulldozer obol-bulldozer bot merged commit ad0c598 into main Apr 22, 2025
15 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/service-name-with-cluster-hash branch April 22, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants