Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: add valIdx to obolapi exit message in expert mode #3146

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

LukeHackett12
Copy link
Contributor

@LukeHackett12 LukeHackett12 commented Jun 19, 2024

Setting validx to be the configured index in the case of expert mode

category: bug
ticket: #3147

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (136723f) to head (04b15c0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3146      +/-   ##
==========================================
- Coverage   56.85%   56.83%   -0.03%     
==========================================
  Files         208      208              
  Lines       29318    29319       +1     
==========================================
- Hits        16670    16662       -8     
- Misses      10809    10816       +7     
- Partials     1839     1841       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/exit_sign.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jun 20, 2024

@LukeHackett12 LukeHackett12 marked this pull request as ready for review June 20, 2024 15:09
@LukeHackett12 LukeHackett12 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 20, 2024
@obol-bulldozer obol-bulldozer bot merged commit 6f6777e into main Jun 20, 2024
13 of 14 checks passed
@obol-bulldozer obol-bulldozer bot deleted the luke/exit-sign-validx branch June 20, 2024 15:24
gsora pushed a commit that referenced this pull request Jun 25, 2024
Setting validx to be the configured index in the case of expert mode

category: bug
ticket: #3147
obol-bulldozer bot pushed a commit that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants