-
-
Notifications
You must be signed in to change notification settings - Fork 102
Add sponsor section component #1536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
M-ayank2005
wants to merge
9
commits into
OWASP:main
Choose a base branch
from
M-ayank2005:sponser
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4fd3b43
updated detailscard component
M-ayank2005 02a0108
checks performed
M-ayank2005 3bef201
Merge branch 'main' into sponser
M-ayank2005 2fe0319
Merge branch 'main' into sponser
kasya e3d38f1
Updated CardDetailsPage.tsx to use map.
M-ayank2005 974d9f7
Merge branch 'main' into sponser
M-ayank2005 97e7001
Merge branch 'main' into sponser
M-ayank2005 a6ab9a7
Merge branch 'main' into sponser
kasya 68c0184
Merge branch 'main' into sponser
kasya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,6 +40,7 @@ export interface DetailsCardProps { | |
geolocationData?: GeoLocDataGraphQL | null | ||
heatmap?: JSX.Element | ||
is_active?: boolean | ||
key?: string | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @M-ayank2005 You added this new property here, but I don't see any key being passed on any page 🤔 |
||
languages?: string[] | ||
pullRequests?: ItemCardPullRequests[] | ||
recentIssues?: ProjectIssuesType[] | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still not addressed. No key is present (ever) so all links only direct to
https://owasp.org/donate/
You need to update the backend to pass in this data for a key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kasya Will it work as expected just by passing key in DetailsCard props?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@M-ayank2005 depends on what you expect to have in that
key
🤔 . But I assume it should.The thing is - you need to actually work on passing it in in this same PR.