Skip to content

Added support for Black Duck Coverity (formerly Synopsys) for newer versions #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added support for Black Duck Coverity (formerly Synopsys) for newer versions #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70588a2
Update CoverityReader.java
Alaeddin03 May 11, 2025
650fec7
added coverity v10 test file
Alaeddin03 May 18, 2025
077a2b6
added tests for coverity v10
Alaeddin03 May 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugin/src/main/java/org/owasp/benchmarkutils/score/parsers/CoverityReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ private TestCaseResult parseCoverityFinding(JSONObject finding, int version) {
TestCaseResult tcr = new TestCaseResult();
String filename = null;

if (version == 3) {
if (version >= 3) {
filename = finding.getString("mainEventFilePathname");
filename = filename.replaceAll("\\\\", "/");
filename = filename.substring(filename.lastIndexOf('/') + 1);
Expand Down
24 changes: 20 additions & 4 deletions plugin/src/test/java/org/owasp/benchmarkutils/score/parsers/CoverityReaderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,23 +30,39 @@

public class CoverityReaderTest extends ReaderTestBase {

private ResultFile resultFile;
private ResultFile resultFile_v3, resultFile_v10;

@BeforeEach
void setUp() {
resultFile = TestHelper.resultFileOf("testfiles/Benchmark_Coverity-v3.0.json");
resultFile_v3 = TestHelper.resultFileOf("testfiles/Benchmark_Coverity-v3.0.json");
resultFile_v10 = TestHelper.resultFileOf("testfiles/Benchmark_Coverity-v10.0.json");
BenchmarkScore.TESTCASENAME = "BenchmarkTest";
}

@Test
public void onlyCoverityReaderReportsCanReadAsTrue() {
assertOnlyMatcherClassIs(this.resultFile, CoverityReader.class);
assertOnlyMatcherClassIs(this.resultFile_v3, CoverityReader.class);
assertOnlyMatcherClassIs(this.resultFile_v10, CoverityReader.class);
}

@Test
void readerHandlesGivenResultFile() throws Exception {
// For Coverity v3.0
CoverityReader reader = new CoverityReader();
TestSuiteResults result = reader.parse(resultFile);
TestSuiteResults result = reader.parse(resultFile_v3);

assertEquals(TestSuiteResults.ToolType.SAST, result.getToolType());
assertTrue(result.isCommercial());
assertEquals("Coverity Code Advisor", result.getToolName());

assertEquals(2, result.getTotalResults());

assertEquals(CweNumber.PATH_TRAVERSAL, result.get(1).get(0).getCWE());
assertEquals(CweNumber.SQL_INJECTION, result.get(2).get(0).getCWE());

// For Coverity v10.0
reader = new CoverityReader();
result = reader.parse(resultFile_v10);

assertEquals(TestSuiteResults.ToolType.SAST, result.getToolType());
assertTrue(result.isCommercial());
Expand Down
107 changes: 107 additions & 0 deletions plugin/src/test/resources/testfiles/Benchmark_Coverity-v10.0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,107 @@
{
"type" : "Coverity issues",
"formatVersion" : 10,
"suppressedIssueCount" : 0,
"issues" : [
{
"mergeKey" : "00000000000000000000000000000000",
"occurrenceCountForMK" : 1,
"occurrenceNumberInMK" : 1,
"checkerName" : "PATH_MANIPULATION",
"subcategory" : "none",
"extra" : "fileName",
"domain" : "STATIC_JAVA",
"mainEventFilePathname" : "somepath\\src\\main\\java\\org\\owasp\\benchmark\\testcode\\BenchmarkTest00001.java",
"strippedMainEventFilePathname" : "somepath\\src\\main\\java\\org\\owasp\\benchmark\\testcode\\BenchmarkTest00001.java",
"mainEventLineNumber" : 0,
"properties" : {},
"functionDisplayName" : "org.owasp.benchmark.testcode.BenchmarkTest00001.doPost(javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse)",
"functionMangledName" : "org.owasp.benchmark.testcode.BenchmarkTest00001.doPost(javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse)",
"ordered" : true,
"events" : [
{
"covLStrEventDescription" : "Lorem Ipsum",
"eventDescription" : "Lorem Ipsum",
"eventNumber" : 0,
"eventTreePosition" : "0",
"eventSet" : 0,
"eventTag" : "tainted_source",
"filePathname" : "somepath\\src\\main\\java\\org\\owasp\\benchmark\\testcode\\BenchmarkTest00001.java",
"strippedFilePathname" : "somepath\\src\\main\\java\\org\\owasp\\benchmark\\testcode\\BenchmarkTest00001.java",
"lineNumber" : 0,
"main" : false,
"moreInformationId" : null,
"remediation" : false,
"events" : null
}
],
"stateOnServer" : null,
"checkerProperties" : {
"category" : "High impact security",
"categoryDescription" : "High impact security",
"cweCategory" : "22",
"issueKinds" : [
"SECURITY"
],
"eventSetCaptions" : [],
"impact" : "High",
"impactDescription" : "High",
"subcategoryLocalEffect" : "Lorem Ipsum",
"subcategoryShortDescription" : "Lorem Ipsum",
"subcategoryLongDescription" : "Lorem Ipsum"
}
},
{
"mergeKey" : "00000000000000000000000000000000",
"occurrenceCountForMK" : 1,
"occurrenceNumberInMK" : 1,
"checkerName" : "SQLI",
"subcategory" : "sink",
"extra" : "sql",
"domain" : "STATIC_JAVA",
"mainEventFilePathname" : "somepath\\src\\main\\java\\org\\owasp\\benchmark\\testcode\\BenchmarkTest00002.java",
"strippedMainEventFilePathname" : "somepath\\src\\main\\java\\org\\owasp\\benchmark\\testcode\\BenchmarkTest00002.java",
"mainEventLineNumber" : 0,
"properties" : {},
"functionDisplayName" : "org.owasp.benchmark.testcode.BenchmarkTest00002.doPost(javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse)",
"functionMangledName" : "org.owasp.benchmark.testcode.BenchmarkTest00002.doPost(javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse)",
"ordered" : true,
"events" : [
{
"covLStrEventDescription" : "Lorem Ipsum",
"eventDescription" : "Lorem Ipsum",
"eventNumber" : 1,
"eventTreePosition" : "0",
"eventSet" : 0,
"eventTag" : "tainted_source",
"filePathname" : "somepath\\src\\main\\java\\org\\owasp\\benchmark\\testcode\\BenchmarkTest00002.java",
"strippedFilePathname" : "somepath\\src\\main\\java\\org\\owasp\\benchmark\\testcode\\BenchmarkTest00002.java",
"lineNumber" : 0,
"main" : false,
"moreInformationId" : null,
"remediation" : false,
"events" : null
}
],
"stateOnServer" : null,
"checkerProperties" : {
"category" : "High impact security",
"categoryDescription" : "High impact security",
"cweCategory" : "89",
"issueKinds" : [
"SECURITY"
],
"eventSetCaptions" : [
"Lorem Ipsum"
],
"impact" : "High",
"impactDescription" : "High",
"subcategoryLocalEffect" : "Lorem Ipsum",
"subcategoryShortDescription" : "Lorem Ipsum",
"subcategoryLongDescription" : "Lorem Ipsum"
}
}
],
"desktopAnalysisSettings" : null,
"error" : null
}