Let CTest succeed on Windows by ignoring CR

[thbeu]

No description provided.

[rouault]

by "Let CTest succeed on Windows by ignoring CR " you mean on Windows with some cygwin-like environment? Because our CI windows-msvc build doesn't run any test

[thbeu]

Well, with this PR I am finally able to run CTest in VS locally:

1>------ Erstellen gestartet: Projekt: ZERO_CHECK, Konfiguration: Debug x64 ------
1>Checking Build System
2>------ Erstellen gestartet: Projekt: RUN_TESTS, Konfiguration: Debug x64 ------
2>Test project C:/Projekte/shapelib/win64
2> Start 1: test1
2>1/4 Test # 1: test1 ............................ Passed 0.76 sec
2> Start 2: test2
2>2/4 Test # 2: test2 ............................ Passed 1.10 sec
2> Start 3: test3
2>3/4 Test # 3: test3 ............................ Passed 0.62 sec
2> Start 4: contrib
2>4/4 Test # 4: contrib .......................... Passed 0.67 sec
2>
2>100% tests passed, 0 tests failed out of 4
2>
2>Total Test time (real) = 3.16 sec
========== Erstellen: 2 erfolgreich, 0 fehlerhaft, 0 aktuell, 0 übersprungen ==========

We could also add -DBUILD_TESTING=ON to the CI, but for Windows I need to know where -DBASH_EXECUTABLE needs to be. I set it to C:/Program Files/Git/bin/bash.exe.

[rouault]

In https://productionresultssa7.blob.core.windows.net/actions-results/5419d2cd-457a-4be4-8002-ca6a92d5b5fb/workflow-job-run-12701e67-bc6c-5a32-3c09-c490b37a48fc/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-03-09T14%3A47%3A13Z&sig=2yrLGlS%2FURGUkB0EOWSpGbf6p0H79bHPefdBjpFvRXs%3D&sp=r&spr=https&sr=b&st=2024-03-09T14%3A37%3A08Z&sv=2021-12-02 log I see "C:\Program Files\Git\bin\git.exe" , so I'd bet "C:/Program Files/Git/bin/bash.exe" would work

[thbeu]

OK, all ✅ now.

[rouault]

thanks for the windows CI improvement. Hopefully I'm not too demanding, but I'd like to be sure we don't regress on Windows with DLL builds. Couldn't we have both a dynamic and static build, and possibly only run the tests with the static one if that's more convenient?

[thbeu]

Uff, took longer than expected.

[rouault]

Thanks, perfect!

[landryb]

fwiw, this add --strip-trailing-cr thing makes all test break on BSD, because that option is a gnu diff extension.

[thbeu]

fwiw, this add --strip-trailing-cr thing makes all test break on BSD, because that option is a gnu diff extension.

Addressed by #152.