gdal.h: add constants for standard metadata domain names and items names#14697
Open
rouault wants to merge 21 commits into
Open
gdal.h: add constants for standard metadata domain names and items names#14697rouault wants to merge 21 commits into
rouault wants to merge 21 commits into
Conversation
rouault
added
the
funded through GSP
rouault
force-pushed
the
GDAL_MDD
branch
2 times, most recently
from
2f6df4d to
21f142f
Compare
Member
Author
|
@dbaston Question regarding naming. Before this PR, we already had a in gdal.h GDALMD_AREA_OR_POINT, GDALMD_AOP_AREA, GDALMD_AOP_POINT for metadata item names and values. I find it a bit unfortunate there's no underscore between GDAL and MD. But I've followed that pattern for other metadata item names (GDALMD_INTERLEAVE, etc.) Otherwise, a potential alternative would be to add new aliases GDAL_MD_ for the 3 existining GDALMD_ , deprecate those older versions, and use GDAL_MD_ for new values Thoughts ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make them more discoverable for users, and limit the risk of typos in our code base (or users' ones)