gdalwarp: allow specifying units of warp memory#10976
Merged
Merged
Conversation
rouault
reviewed
Oct 9, 2024
Member
|
CI failure on gdrivers/gti.py::test_gti_stac_geoparquet is unrelated and solved in latest master HEAD |
Collaborator
|
Maybe it is worth documenting the valid units and usage for users. The units seem to be k, m, g or kb, mb, gb. All combinations of upper and lower case are accepted, and the unit can follow the numeric value with or without space. Is that right? |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Validates the
-wmargument to gdalwarp so that invalid values cause a failure. Also allows more clear specification of memory amount with units (-wm 1G,-wm 200MB), or as a fraction of usable memory (-wm 10%). Probably overkill for this purpose but I think there are other places the same function could be used, such as the parsing ofGDAL_CACHEMAX.What are related issues/pull requests?
#10888, #10889
Tasklist