SSH Keyfile location support for systemd launcher/cluster#863
SSH Keyfile location support for systemd launcher/cluster#863johrstrom merged 4 commits intoOSC:masterfrom
Conversation
|
We (OSC) use |
Hopefully make this "more ruby" like.
remove duplicate line.
removed duplicate end. My poor copy & paste skills...
|
Sorry for the delay - I'm still working through test cases that should have caught that issue (if there was one?) |
🤦♂️ I added a test for the linux_host adapter, not the systemd adapter. I'll get this merged shortly and add some tests for the same. |
johrstrom
left a comment
There was a problem hiding this comment.
Thanks for working through this with me!
No worries, I'm not well versed in git or ruby so I can only apologise for being slow and cumbersome. |
No issues at all. I'm happy to get a contribution in any form. Thanks again! |
This should give some (albeit poor quality) support for alternative ssh keyfile locations using the systemd launcher.
Our use case is so users don't have to think about ssh key generation etc to reduce a barrier of entry.
I don't write ruby so this is probably a mess.