SSH Keyfile location support for systemd launcher/cluster #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
reviewed
Jan 28, 2025
|
We (OSC) use |
Hopefully make this "more ruby" like.
remove duplicate line.
removed duplicate end. My poor copy & paste skills...
|
Sorry for the delay - I'm still working through test cases that should have caught that issue (if there was one?) |
🤦♂️ I added a test for the linux_host adapter, not the systemd adapter. I'll get this merged shortly and add some tests for the same. |
johrstrom
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should give some (albeit poor quality) support for alternative ssh keyfile locations using the systemd launcher.
Our use case is so users don't have to think about ssh key generation etc to reduce a barrier of entry.
I don't write ruby so this is probably a mess.