-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CMake #59
Refactor CMake #59
Conversation
Ready to merge as change is atomic and tests are passing |
8fcca3e
to
26fbfe5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running make test_install
the consumer app build fails with following error:
-- HIP include directories: /opt/rocm-5.6.0/include
-- Configuring done
CMake Error at /ccs/home/peles/local/resolve-frontier/share/resolve/cmake/ReSolveTargets.cmake:64 (set_target_properties):
The link interface of target "ReSolve::resolve_hip" contains:
roc::rocblas
but the target was not found. Possible reasons include:
* There is a typo in the target name.
* A find_package call is missing for an IMPORTED target.
* An ALIAS target is missing.
Call Stack (most recent call first):
/ccs/home/peles/local/resolve-frontier/share/resolve/cmake/ReSolveConfig.cmake:5 (include)
CMakeLists.txt:10 (find_package)
I think this needs just a little tweak to get it to work. I am not sure what is going on, but sometimes HIP find function does not like roc::
namespace.
Otherwise changes look good!
include_directories
everywhere (closes Use target commands to specify include directories in ReSolve #15)I will close remainder of #15 for AMD in Incline PR #53