Declutter functionality test #218
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good and tests pass. Just fix the merge conflict. |
maksud
reviewed
Jan 29, 2025
| ReSolve::VectorHandler vector_handler(&workspace); | ||
| ReSolve::GramSchmidt GS(&vector_handler, ReSolve::GramSchmidt::CGS2); | ||
| ReSolve::LinSolverIterativeFGMRES FGMRES(&matrix_handler, &vector_handler, &GS); | ||
| FGMRES.setMaxit(200); |
There was a problem hiding this comment.
For test I guess it is okay, but as you are using CliOptions, it may be well-suited to document how you use it here. So, if the CliOptions has been provided for Maximum iterations use it or use the default is 200.
There was a problem hiding this comment.
This is a very good point @maksud. This will also simplify the test case further by hiding data conversion from the user.
maksud
approved these changes
Jan 29, 2025
shakedregev
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal how to declutter functionality tests and expand testing scope. Checking results and computing different error norms is moved into a testing helper class to make the main body of the test cleaner and more focused on solver calls. The proposal also includes using command line input to configure tests and generating multiple tests from a single source file.