-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change member functions and data names in vector and matrix classes to be more consistent #208
Conversation
9c184a1
to
b08a055
Compare
Rebased to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing, looks good besides the minor comments
I haven't looked at codes changes, but tests are passing for me as well (tested on Frontier). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main concern is that now we have copyData[To/From]
instead of update
but at the same time, we kept setDataUpdated
which makes things slightly more confusing.
I am not sure if this makes things more confusing. The purpose of |
Change names of methods and data members in vector and matrix classes to be more consistent and accurate. Specific changes include:
Sparse
,Csr
,Csc
,Coo
)setMatrixData
tosetDataPointers
setNewValues
tosetValuesPointers
updateData
tocopyData
copyData
toconst
arrays.owns_*_data_
toowns_*_sparsity_pattern_
deepCopyVectorData
tocopyDataTo
update
tocopyDataFrom
.Fixes #167