Rename copyData -> syncData and ensure correct flags set when syncing
#199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two issues addressed here:
copyData->syncData. MethodssyncDatasynchronize data between the host and device within the same vector or matrix object. "Copy" often suggests data is copied from/to another object. Resolves Consider renaming matrix::Sparse::copyData to matrix::Sparse::SyncData #187.h_data_updated_is set totrueand device flagd_data_updated_is set tofalse. A sync method needs to be used if one wants to update both. Resolves When only host is updated, the device is out of date (and vice versa) #126.Both, sync and update methods need to check if the operations are meaningful. For example if syncing device memory space, the host needs to be up-to-date.