Skip to content

Conversation

@pelesh
Copy link
Collaborator

@pelesh pelesh commented Oct 9, 2024

There are two issues addressed here:

Both, sync and update methods need to check if the operations are meaningful. For example if syncing device memory space, the host needs to be up-to-date.

@pelesh pelesh added bug Something isn't working enhancement New feature or request labels Oct 9, 2024
@pelesh pelesh self-assigned this Oct 9, 2024
@pelesh pelesh marked this pull request as draft October 9, 2024 04:08
@pelesh pelesh marked this pull request as ready for review October 9, 2024 14:22
@pelesh
Copy link
Collaborator Author

pelesh commented Oct 12, 2024

Resolves #188.

@pelesh pelesh merged commit e5973c8 into develop Oct 12, 2024
4 checks passed
@pelesh pelesh deleted the copy2sync-dev branch March 13, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider renaming matrix::Sparse::copyData to matrix::Sparse::SyncData When only host is updated, the device is out of date (and vice versa)

3 participants