Skip to content

removing the first beginReporStep() for well model #6188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GitPaean
Copy link
Member

it will be called in a later stage.

creating the test to evaluate whether it impacts any situations.

it will be called in a later stage.
@GitPaean
Copy link
Member Author

jenkins build this please

@GitPaean
Copy link
Member Author

GitPaean commented Apr 22, 2025

To the extent that jekins test can cover, it does not look like it causes any regression. I am marking the PR to be ready for review and potentially to get the PR in.

@GitPaean GitPaean marked this pull request as ready for review April 22, 2025 12:11
@GitPaean GitPaean requested a review from bska April 22, 2025 12:12
@GitPaean
Copy link
Member Author

For the information, the WellModel::beginReportStep() will be called in a later stage at

this->solver_->model().beginReportStep();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant