PAC/BTI enablement in TS #771
Conversation
|
This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed pull request at any time. |
fvp-psa-sp.mk
Outdated
| @@ -13,12 +13,15 @@ TS_UEFI_INTERNAL_CRYPTO ?= n | |||
| SP_PACKAGING_METHOD ?= embedded | |||
| SPMC_TESTS ?= n | |||
| SPMC_AT_EL ?= 1 | |||
| TS_BTI_ENABLED ?= unset | |||
There was a problem hiding this comment.
It doesn't make much sense to introduce TS_BTI_ENABLED in the parent commit only to remove it in this one. Please squash the two commits into "fvp: add PAC and BTI support".
There was a problem hiding this comment.
Yes, you are right. Squashed them into a single commit.
gabor-toth-arm
force-pushed
the
master
branch
from
b6477ef
to
8a0b7be
Compare
gabor-toth-arm
force-pushed
the
master
branch
from
8a0b7be
to
80d33b1
Compare
|
Hi @jforissier @etienne-lms ! Could we merge this commit if there are no more findings or is there anything else I should correct? |
|
|
gabor-toth-arm
force-pushed
the
master
branch
from
80d33b1
to
d8f005d
Compare
There was a problem hiding this comment.
Acked-by: Etienne Carriere <[email protected]> with s/BRANCH_PROTECTION/TS_BRANCH_PROTECTION/ in commit message.
PAC and BTI are enabled by the same compiler option, so instead of having separate variables, they are both controlled by TS_BRANCH_PROTECTION variable, similar way as in TF-A. Signed-off-by: Gabor Toth <[email protected]> Acked-by: Jerome Forissier <[email protected]> Acked-by: Etienne Carriere <[email protected]>
gabor-toth-arm
force-pushed
the
master
branch
from
d8f005d
to
1f34a3d
Compare
|
Hi @jenswi-linaro ! Could you take a look at this change and merge it? |
|
|
|
This is ready to be merged. |
Should be merged together with or after the listed PR-s: