Skip to content

[refactor] 모임 상세에서 약속 상세로 이동하기 위한 코드 리팩토링 #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

JinUng41
Copy link
Contributor

🔗 연결된 이슈

📄 작업 내용

  • Cell Delegate 메서드 didSelectItemAt 을 이용하여 셀 선택시, 뷰모델 배열에 접근하여 선택된 모임을 추출
  • print문은 추후 삭제 요망 (@youz2me )
구현 내용 사진
GIF

@JinUng41 JinUng41 added ♻️ refactor 기존 코드를 리팩토링하거나 수정하는 등 사용 (생산적인 경우) 💙 JinUng 걸스 토크에 미쳐보고 싶다면 labels Jul 18, 2024
@JinUng41 JinUng41 self-assigned this Jul 18, 2024
Copy link
Member

@youz2me youz2me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 고생하셨어요 ~~

image

Copy link
Member

@hooni0918 hooni0918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿!

Copy link
Member

@mmaybei mmaybei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 냐미!

@@ -93,7 +93,7 @@ final class MeetingPromiseCell: BaseCollectionViewCell {

extension MeetingPromiseCell {
func configure(dDay: Int, name: String, date: String, time: String, place: String) {
let dDayText = dDay == 0 ? "day" : "\(dDay)"
let dDayText = dDay == 0 ? "Day" : "\(dDay)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋ 수정 감사해요!~~

@JinUng41 JinUng41 merged commit 191779d into suyeon Jul 18, 2024
@JinUng41 JinUng41 deleted the refactor/#221-data-binding-promise-info branch July 18, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💙 JinUng 걸스 토크에 미쳐보고 싶다면 ♻️ refactor 기존 코드를 리팩토링하거나 수정하는 등 사용 (생산적인 경우)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor] 모임 상세에서 약속 상세로 이동하기 위한 코드 리팩토링
4 participants