Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: do not break custom fields when enabling JA4 (7.x) #11843

Open
wants to merge 1 commit into
base: main-7.0.x
Choose a base branch
from

Conversation

satta
Copy link
Contributor

@satta satta commented Sep 27, 2024

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/7286

Describe changes:

  • Ensure tls_ctx->fields is not overwritten when selecting JA4 log output.

@satta satta changed the title tls: do not break custom fields when enabling JA4 tls: do not break custom fields when enabling JA4 (7.x) Sep 27, 2024
@jufajardini
Copy link
Contributor

Thanks! Creating a test for this also exposed the fact that our json schema is missing two tls custom fields...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants