threads: don't drop capabilities for packet threads #11839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the call to SCDropCaps for packet processing threads. This logic in this function is required to setup packet processing even when the thread is provided by a library user, in which case Suricata should not be touching is capabilities. As SCDropCaps is currently a no-op its clear this feature needs to be (re)designed properly, taking into consideration library users as well. Related ticket: https://redmine.openinfosecfoundation.org/issues/2375
|
Using this to discuss possibly removing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11839 +/- ##
==========================================
- Coverage 82.60% 79.01% -3.59%
==========================================
Files 912 912
Lines 249351 249173 -178
==========================================
- Hits 205965 196886 -9079
- Misses 43386 52287 +8901
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 22885 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the call to SCDropCaps for packet processing threads. This
logic in this function is required to setup packet processing even
when the thread is provided by a library user, in which case Suricata
should not be touching is capabilities.
As SCDropCaps is currently a no-op its clear this feature needs to
be (re)designed properly, taking into consideration library users as
well.
Related ticket: https://redmine.openinfosecfoundation.org/issues/2375