-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yaml: Add check of allocation for node object #11822
yaml: Add check of allocation for node object #11822
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11822 +/- ##
==========================================
+ Coverage 82.58% 82.60% +0.02%
==========================================
Files 914 914
Lines 249500 249502 +2
==========================================
+ Hits 206045 206102 +57
+ Misses 43455 43400 -55
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would like the ticket number in the commit message cf https://docs.suricata.io/en/latest/devguide/contributing/code-submission-process.html#commits
Also, I see some unit tests do not check it like ConfNode *parent = ConfNodeNew();
Thanks for this report, how did you find it ? |
Sure, will update it. This issue was found by some static analysis tools |
Nice, could you share which one? |
Replaced by: #11847 |
Fix potential dereferece of nullptr in case of unsuccessful allocation
of memory for list node
Bug: #7270
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7270
Describe changes:
fail
marker;