Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the napatech packet source to a plugin #11819

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jlucovsky
Copy link
Contributor

Continuation of #11687

This PR contains the changes to distribute and build the Napatech source modules as a "capture plugin".

Describe changes:

  • Converted the Napatech source modules to be suitable for a capture plugin
  • User-level upgrade documentation
  • Rebase and manual application of 96a0ffa to file that was deleted and then added.
  • Doc update -- use "Napatech" instead of "NAPATECH"
  • Revert unnecessary change to decode module name -- NapatechDecode.
  • Combine like commits (remove unnecessary fixup commit)
  • Doc tweaks per review feedback

Updates:

  • Rebase

Provide values to any of the below to override the defaults.

  • To use an LibHTP, Suricata-Verify or Suricata-Update pull request,
    link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

jlucovsky and others added 7 commits September 23, 2024 09:13
Re-introduce support for command line argument "--napatech"

Issue: 7165
Issue: 7165

Plugins can't be build using the standard autoconf/automake
methods. We can get around this by creating our own Makefiles, but
they're often less portable.

For now, fail during ./configure instead of during compile.
Original limit was due to a specific data structure.

(lifted from 96a0ffa)
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.60%. Comparing base (7ab8334) to head (7e640e4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11819      +/-   ##
==========================================
+ Coverage   82.58%   82.60%   +0.02%     
==========================================
  Files         914      912       -2     
  Lines      249500   249473      -27     
==========================================
+ Hits       206045   206077      +32     
+ Misses      43455    43396      -59     
Flag Coverage Δ
fuzzcorpus 60.57% <ø> (+0.14%) ⬆️
livemode 18.71% <ø> (-0.01%) ⬇️
pcap 43.92% <ø> (-0.15%) ⬇️
suricata-verify 62.04% <ø> (+0.01%) ⬆️
unittests 58.96% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.uptime 649 628 96.76%

Pipeline 22794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants