af-packet: speed up thread sync during startup #11806
Conversation
Threads are initialized sequentially to allow for a predictable mapping of threads and queues. Not all parts of the start up need to be done sequentially. The setting up of the rings can be very expensive, taking of a couple of hundred milliseconds. The ring setup doesn't need to be done sequentially though. This patch releases the thread early, after bind but before the ring setups.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11806 +/- ##
=========================================
Coverage ? 82.60%
=========================================
Files ? 919
Lines ? 249008
Branches ? 0
=========================================
Hits ? 205701
Misses ? 43307
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 22758 |
There was a problem hiding this comment.
Thanks for the work. Should there be a ticket ?
CI : ok
Commits segmentation : ok
Commit messages : ok, except there is no redmine ticket id ?
Git ID set : ok
CLA : you already contributed
Doc update : not needed
Redmine ticket : 🟡 there should be one, right ?
Rustfmt : no rust
Tests : I do not think we have a good way to test such optimizations, do we ?
Dependencies added: none
Code : good
|
Replaced by #11828 |
Threads are initialized sequentially to allow for a predictable mapping of threads and queues. Not all parts of the start up need to be done sequentially. The setting up of the rings can be very expensive, taking of a couple of hundred milliseconds. The ring setup doesn't need to be done sequentially though.
This patch releases the thread early, after bind but before the ring setups.
Replaces #11189