dpdk: add initial unittests for DPDK codebase v4 #11728
Conversation
To better control the values within the variables and to prepare for the follow-up unit tests, the variable was moved into global scope and should accessed only by functions. This allows reinstantination of the variable value - needed for unit tests.
The function would incorrectly perform XOR operation. While it worked when the worker cores were occupying all cores, it is still not correct operation. The example might be when a core would be affined to only management and not worker threads. With the XOR operation it would set affinity to also worker set. (1 XOR 0 -> 1 where in fact the desired outcome is 0)
For the upcoming changes, skipping a unit test might be beneficial when testing a function that retrieves hardware data. This can e.g. depend on the number of CPU cores and systems that does not meet the required test criteria will need to omit the tests. The tests should always target minimal system requirements
… requirements of tests
…gnment Ticket: 6927
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11728 +/- ##
==========================================
+ Coverage 82.63% 82.64% +0.01%
==========================================
Files 919 919
Lines 248925 249204 +279
==========================================
+ Hits 205703 205961 +258
- Misses 43222 43243 +21
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: ERROR: QA failed on SURI_TLPR1_alerts_cmp.
Pipeline 22482 |
| */ | ||
| #define SKIP(reason) \ | ||
| do { \ | ||
| SCLogInfo("Test skipped: %s", reason); \ |
There was a problem hiding this comment.
no need to SCLogInfo as we will have the printf("skip\n"); after ?
There was a problem hiding this comment.
./src/suricata -u -U DPDKRunmodeSetThreads01
Test DPDKRunmodeSetThreads01 : Info: affinity: Test skipped: not enough cpus in the system, the test requires at least 32 cores [UnitTestsUtilAffinityVerifyCPURequirement:util-affinity.c:347]
skip
==== TEST RESULTS ====
PASSED: 0
SKIPPED: 1
FAILED: 0
======================
This was the idea - to only tell the user that the test was skipped but a responsible test writer should explain why the test was skipped and what prerequirements were not met for the test.
There was a problem hiding this comment.
The macro SKIP_INCOMPATIBLE_ENVIRONMENT could skip the tests not only based on CPU count but potentially on other requirements as well.
| @@ -52,7 +52,10 @@ uint16_t BondingMemberDevicesGet( | |||
| { | |||
| #ifdef HAVE_DPDK_BOND | |||
| #if RTE_VERSION >= RTE_VERSION_NUM(23, 11, 0, 0) | |||
| #pragma GCC diagnostic push | |||
| #pragma GCC diagnostic ignored "-Wdeprecated-declarations" | |||
There was a problem hiding this comment.
Why do we need this ? Why cannot we have a non deprecated declaration ?
There was a problem hiding this comment.
Non deprecated declaration is not possible as DPDK in 23.11 marked the old API (slave) as deprecated and the new API (member) as experimental. On both versions of this API therefore a warning is thrown. I circumvented this by allowing experimental API in the Github Actions.
| @@ -88,10 +88,11 @@ ThreadsAffinityType * GetAffinityTypeFromName(const char *name); | |||
|
|
|||
| uint16_t AffinityGetNextCPU(ThreadsAffinityType *taf); | |||
| uint16_t UtilAffinityGetAffinedCPUNum(ThreadsAffinityType *taf); | |||
| #ifdef HAVE_DPDK | |||
| #if defined(__linux__) | |||
There was a problem hiding this comment.
Is there #if defined(UNITTESTS) missing ?
It is in the C file, but not here...
|
goto #12081 |
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6927
Follow-up of: #11494
Describe changes:
v4
v3
v2
v1