detect: absent keyword to test absence of sticky buffer #11423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THashInitConfig may not allocate array and increase memuse. Such a failure leads to THashShutdown which should not decrease the memuse. Ticket: 7135
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11423 +/- ##
========================================
Coverage 82.44% 82.45%
========================================
Files 938 938
Lines 248086 248230 +144
========================================
+ Hits 204534 204669 +135
- Misses 43552 43561 +9
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Draft to check CI with fixup commit |
Ticket: 2224 It takes an argument to match only if the buffer is absent, or it can still match if the buffer is present, but we test the absence of some content
catenacyber
force-pushed
the
detect-negated-content-absent-buffer-2224-v20
branch
from
2becf58
to
08038bd
Compare
|
Information: QA ran without warnings. Pipeline 21385 |
I think there's a new different failure w the fuzz job. Your PR seems to be doing well. |
|
Rebased in #11459 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2224
Describe changes:
absentkeyword to match on absent bufferSV_BRANCH=OISF/suricata-verify#1957
#11375 with newer tests, some engine analysis, and ability to express "if there is no user agent, or if it exists and is XYZ, then match"