Migrate to pure julia #62
Conversation
Project.toml
Outdated
| @@ -6,6 +6,7 @@ version = "0.6.1" | |||
| [deps] | |||
| CSV = "336ed68f-0bac-5ca0-87d4-7b16caf5d00b" | |||
| CairoMakie = "13f3f980-e62b-5c42-98c6-ff1f3baf88f0" | |||
| DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0" | |||
There was a problem hiding this comment.
Is this really necessary? I think it's just use in tandem with CSV.jl, and we saw that those are quite easy to read, so I'd drop this dependency unless it's really necessary.
There was a problem hiding this comment.
You're right, not using DataFrames with CSV is almost transparent. This dependency was removed in a89c40e
test/params_construction.jl
Outdated
| function params_constructor_specified(; save_refs::Bool = true) # TODO: change | ||
| function params_constructor_specified(; save_refs::Bool = false) | ||
|
|
||
| rgi_paths = JSON.parsefile("/tmp/OGGM/ODINN_prepro/rgi_paths.json") # TODO: find a way to automatically determine the path |
There was a problem hiding this comment.
Do we want to always stick to this path or we want to make it dynamic?
There was a problem hiding this comment.
We want it to be dynamic and this needs to be based on the preprocessed data that are downloaded in the __init__. All of this was implemented in a89c40e
There was a problem hiding this comment.
Thanks for the review! Data are now automatically downloaded. We need to put the files in an appropriate server (cf #63) but for the moment a google drive folder makes the job.
Project.toml
Outdated
| @@ -6,6 +6,7 @@ version = "0.6.1" | |||
| [deps] | |||
| CSV = "336ed68f-0bac-5ca0-87d4-7b16caf5d00b" | |||
| CairoMakie = "13f3f980-e62b-5c42-98c6-ff1f3baf88f0" | |||
| DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0" | |||
There was a problem hiding this comment.
You're right, not using DataFrames with CSV is almost transparent. This dependency was removed in a89c40e
test/params_construction.jl
Outdated
| function params_constructor_specified(; save_refs::Bool = true) # TODO: change | ||
| function params_constructor_specified(; save_refs::Bool = false) | ||
|
|
||
| rgi_paths = JSON.parsefile("/tmp/OGGM/ODINN_prepro/rgi_paths.json") # TODO: find a way to automatically determine the path |
There was a problem hiding this comment.
We want it to be dynamic and this needs to be based on the preprocessed data that are downloaded in the __init__. All of this was implemented in a89c40e
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## purejulia #62 +/- ##
============================================
Coverage ? 29.51%
============================================
Files ? 15
Lines ? 603
Branches ? 0
============================================
Hits ? 178
Misses ? 425
Partials ? 0 ☔ View full report in Codecov by Sentry. |
albangossard
force-pushed
the
agossard/migratePureJulia
branch
from
0f3df9f to
4182903
Compare
albangossard
force-pushed
the
agossard/migratePureJulia
branch
from
4182903 to
6834b5d
Compare
* migrate all 2D files to purejulia * update test references * remove PyCall dependencies in the 1D files * automatic download of preprocessed data + remove DataFrames dependency * try to remove Python from the CI * remove remaining implicit dependencies to Python objects * create get_rgi_paths * fix various bugs * remove absolute paths from get_rgi_paths to make the tests platform agnostic * fix bugs with the climate_2D_step structure * some cleaning * bump version
…ng on PyCall (#65) * Add version number to all dependencies * Update CI.yml with new micromamba version * Update environment.yml * Changing python imports * Python environment working in local - testing CI * Update CI.yml - Testing in multiple versions & OS * Update CI.yml * Remove cache environments * Remove unnecessary `which python` * Update CI.yml - bring some specific os info * Rename environment * Update CI.yml - Ask more network variables * Update CI.yml - typo in NetworkOptions * Ping path for Mac - not working for Ubuntu * Update CI.yml - checking path * Update CI.yml * Update CI.yml * Update CI.yml * Update CI.yml * Update CI.yml * Update config.jl - remove catch warning * Update CI.yml - Now maybe exporiting global env variable * Update CI.yml - Fix export on environmnet names * Update CI.yml - bump micromamba version * testing idea from the discourse * Update CI.yml * Update action version of `checkout` and `setup-python` * Update CI.yml - fix typo with SSH -> SSL * Update CI.yml - export SSL_CERT_FILE * Update CI.yml - Change Python path * Update CI.yml * Update CI.yml * Update CI.yml - Trying to reproduce past behaviour * Update CI.yml * Update config.jl - remove try's * Update CI.yml - Julia 1.11 * Update CI.yml - remove Python setup and let this to micromamba * Update CI.yml - conda -> micromamba for environment inspection * Remove some redundancy and things that may fail * Update CI.yml * Update CI.yml * [WIP] Removing Python dependencies and migrating to Rasters.jl Ongoing fix, still a few lines missing, and tests have still not been run. * Remove environment.yml file * [WIP] continue the migration, tests of params_construction.jl are passing * Migrate to pure julia (#62) * migrate all 2D files to purejulia * update test references * remove PyCall dependencies in the 1D files * automatic download of preprocessed data + remove DataFrames dependency * try to remove Python from the CI * remove remaining implicit dependencies to Python objects * create get_rgi_paths * fix various bugs * remove absolute paths from get_rgi_paths to make the tests platform agnostic * fix bugs with the climate_2D_step structure * some cleaning * bump version * fix dependencies after rebase --------- Co-authored-by: Facundo Sapienza <[email protected]> Co-authored-by: Jordi <[email protected]>
What has been done
The tests
test/runtests.jlpassed on my local branch ✔️Next steps
Put OGGM data on a serverAutomatically pull these dataRemoveoggm_envfrom the CIPursue the migration in the other repos