add --emit-file option to emit .wat files

[vasucp1207]

Issue #247

Add --emit-flag flag to emit file.wat from file.wasm

[zapashcanon]

Hi!

Welcome to the project, and thanks for the PR! :)

I added some minor comments. Maybe you could also add an entry in CHANGES.md ?

I have two other questions, it's a little bit unusual for -o to be a simple flag, one usually expects something like -o outputname.wat. We could either rename -o to --emit-file or change -o from a flag to a parameter expecting an actual file name. WDYT ?

Could you add a small test in test/wasm2wat/ ? You would have to create a file named emit.t for instance, which would have the following content:

test that we can emit to a file:
  $ owi wasm2wat m.wasm --emit-file
  $ cat m.wat

Then you would run dune runtest (it may take a while). You'll then see some output, if it looks correct, you should run dune promote and commit the changes.

You'll need to run the dune runtest+dune promote procedure anyway in order to update the manual pages that are making the CI fail. :)

[vasucp1207]

Hi!

Welcome to the project, and thanks for the PR! :)

I added some minor comments. Maybe you could also add an entry in CHANGES.md ?

I have two other questions, it's a little bit unusual for -o to be a simple flag, one usually expects something like -o outputname.wat. We could either rename -o to --emit-file or change -o from a flag to a parameter expecting an actual file name. WDYT ?

Because wasm2wat can take multiple files as arguments, I think it's not a good idea to change -o flag to a parameter that expects a file name, --emit-file is better because it can handle multiple files. Correct me, If I am missing something.

Could you add a small test in test/wasm2wat/ ? You would have to create a file named emit.t for instance, which would have the following content:

test that we can emit to a file:
  $ owi wasm2wat m.wasm --emit-file
  $ cat m.wat

Then you would run dune runtest (it may take a while). You'll then see some output, if it looks correct, you should run dune promote and commit the changes.

You'll need to run the dune runtest+dune promote procedure anyway in order to update the manual pages that are making the CI fail. :)

[zapashcanon]

Because wasm2wat can take multiple files as arguments, I think it's not a good idea to change -o flag to a parameter that expects a file name, --emit-file is better because it can handle multiple files. Correct me, If I am missing something.

Indeed, I forgot about it being able to handle multiple files... --emit-file is better indeed.

[zapashcanon]

Thanks, the tests look good now. I'm going to merge once the two reviews about src/cmd/cmd_wasm2wat.ml are addressed.

[zapashcanon]

Thanks!