-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cob_call_with_exception_check (test 771) #129
Fix cob_call_with_exception_check (test 771) #129
Conversation
02f7de6
to
52f4cb5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## gcos4gnucobol-3.x #129 +/- ##
==================================================
Coverage 65.74% 65.74%
==================================================
Files 32 32
Lines 59092 59096 +4
Branches 15575 15576 +1
==================================================
+ Hits 38849 38854 +5
Misses 14262 14262
+ Partials 5981 5980 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to skip the complete termination?
I think we should do the screenio cleanup - but only if that was done after the call to cob_call_with_exception_check()
.
We very likely need to call the exit handlers, as those can be COBOL programs which need the state "at exit", not any previous state we longjmp to. But then those should not be executed after the longjmp.
We possibly should add some additional testcases that combine cob_call_with_exception_check()
with the scenario "exception and exit handlers setup".
52f4cb5
to
2db2b90
Compare
Well, in #125, you suggest :
Since Anyways, I pushed an improved version, where only the last bits of termination are delayed, ie only the following calls :
Cleanup is automatically performed after the longjump, so no need to call |
2db2b90
to
ccfebd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's very clean. Please add a changelog entry, then this is good for svn (sight, I won't finish the parts to make svn ready for more commits until moid/end next week).
ccfebd6
to
44bc538
Compare
No description provided.