[16.0][FIX] web_widget_product_label_section_and_note: Use a flag to change the icon based on product visibility. #3083
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the icon based on product visibility. Before this commit, when isProductVisible was disabled and the user changed the label, this caused isProductVisible to change its value. After this commit, changing the label no longer modifies isProductVisible.
pedrobaeza
approved these changes
Feb 8, 2025
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 1cd4b37. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
16.0-fix-web_widget_product_label_section_and_note
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, when
isProductVisiblewas disabled and the user changed the label, this causedisProductVisibleto change its value. After this commit, changing the label no longer modifiesisProductVisible.Backport of 65af83d
TT54841
@Tecnativa @pedrobaeza Please take a look according to your comment from the migration PR.