Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][ADD] stock_picking_stage #2276

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[18.0][ADD] stock_picking_stage #2276

wants to merge 1 commit into from

Conversation

imlopes
Copy link

@imlopes imlopes commented Feb 27, 2025

image

Ricardoalso
Ricardoalso approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@Ricardoalso Ricardoalso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment

Technically LGTM

jbaudoux
jbaudoux reviewed Mar 7, 2025
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also squash commits?

@imlopes imlopes force-pushed the 18.0-add-stock_picking_stage branch from 974cea1 to 85ad524 Compare March 10, 2025 15:26
@Ricardoalso
[18.0][ADD] stock_picking_stage
79c25c9 
[IMP] rename fields according to Ricardo's comment

Update stock_picking_stage/views/stock_picking_view.xml

Co-authored-by: Ricardoalso <[email protected]>

Update stock_picking_stage/models/stock_picking.py

Co-authored-by: Ricardoalso <[email protected]>

Update stock_picking_stage/views/stock_picking_view.xml

Co-authored-by: Ricardoalso <[email protected]>
@imlopes imlopes force-pushed the 18.0-add-stock_picking_stage branch from 85ad524 to 79c25c9 Compare March 10, 2025 15:27
HaraldPanten
HaraldPanten approved these changes Mar 10, 2025
View reviewed changes
Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working fine in runboat. Functional review.

@HaraldPanten
Copy link

HaraldPanten commented Mar 14, 2025 •
edited
Loading

@imlopes Why did you leave all this description in your commit message?
Captura de pantalla 2025-03-14 a las 16 45 47

@rousseldenis rousseldenis added this to the 18.0 milestone Mar 14, 2025
@rousseldenis
Copy link
Contributor

@imlopes Could you remove unrelated static/icons ?

@rousseldenis
Copy link
Contributor

It could be great to explain in CONTEXT.md what will represent the stage from picking state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouitmil wouitmil wouitmil approved these changes

@jbaudoux jbaudoux jbaudoux left review comments

@Ricardoalso Ricardoalso Ricardoalso approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.
7 participants
@imlopes @HaraldPanten @rousseldenis @wouitmil @jbaudoux @Ricardoalso @OCA-git-bot