-
-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][ADD] stock_picking_stage #2276
base: 18.0
Are you sure you want to change the base?
Conversation
imlopes
commented
Feb 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment
Technically LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also squash commits?
974cea1
to
85ad524
Compare
[IMP] rename fields according to Ricardo's comment Update stock_picking_stage/views/stock_picking_view.xml Co-authored-by: Ricardoalso <[email protected]> Update stock_picking_stage/models/stock_picking.py Co-authored-by: Ricardoalso <[email protected]> Update stock_picking_stage/views/stock_picking_view.xml Co-authored-by: Ricardoalso <[email protected]>
85ad524
to
79c25c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working fine in runboat. Functional review.
@imlopes Why did you leave all this description in your commit message? |
@imlopes Could you remove unrelated static/icons ? |
It could be great to explain in CONTEXT.md what will represent the stage from picking state |